docs: use inject() and bootstrapApplication in dialog, snack-bar, and bottom-sheet docs#32839
Open
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Open
docs: use inject() and bootstrapApplication in dialog, snack-bar, and bottom-sheet docs#32839yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
… bottom-sheet docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation update.
What is the current behavior?
The dialog, snack-bar, and bottom-sheet docs use outdated patterns:
@Inject(TOKEN)for data injection tokensDialogRef/MatDialogRef@NgModuleprovider blocks for default options'../dialog'instead of package pathsRelates to #32709
What is the new behavior?
inject()function@Inject(TOKEN)withinject<Type>(TOKEN)@NgModuleprovider blocks withbootstrapApplication@angular/material/dialog,@angular/material/snack-bar,@angular/material/bottom-sheet,@angular/cdk/dialog)Files changed
src/cdk/dialog/dialog.mdDialogRefconstructor ->inject(),@Inject(DIALOG_DATA)->inject(),@NgModule->bootstrapApplicationsrc/material/dialog/dialog.mdMatDialogRefconstructor ->inject(),@Inject(MAT_DIALOG_DATA)->inject(),@NgModule->bootstrapApplication, fix import pathsrc/material/snack-bar/snack-bar.md@Inject(MAT_SNACK_BAR_DATA)->inject(),@NgModule->bootstrapApplication, fix import pathsrc/material/bottom-sheet/bottom-sheet.md@Inject(MAT_BOTTOM_SHEET_DATA)->inject(),@NgModule->bootstrapApplication, fix import path